Messages in this thread | | | Date | Tue, 10 Oct 2023 17:07:00 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 23/23] locktorture: Check the correct variable for allocation failure |
| |
On Tue, Oct 10, 2023 at 06:55:40AM -0700, Paul E. McKenney wrote: > On Tue, Oct 10, 2023 at 01:59:21PM +0200, Frederic Weisbecker wrote: > > From: Dan Carpenter <dan.carpenter@linaro.org> > > > > There is a typo so this checks the wrong variable. "chains" plural vs > > "chain" singular. We already know that "chains" is non-zero. > > > > Fixes: 7f993623e9eb ("locktorture: Add call_rcu_chains module parameter") > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > > Signed-off-by: Frederic Weisbecker <frederic@kernel.org> > > Reviewed-by: Paul E. McKenney <paulmck@kernel.org> > > A name change to increase the Hamming distance would of course also be > good, though less urgent. ;-)
"Hamming distance" is such a great phrase. I'm going to use that every time I complain about confusingly similar variable names going forward.
regards, dan carpenter
| |