Messages in this thread | | | Date | Tue, 10 Oct 2023 14:51:30 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH 1/2] dt-bindings: iio: light: Avago APDS9306 |
| |
On Mon, 9 Oct 2023 02:18:56 +1030 Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> wrote:
> Add devicetree bindings for Avago APDS9306 Ambient Light Sensor. > > Signed-off-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> > --- > .../bindings/iio/light/avago,apds9306.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml > > diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml > new file mode 100644 > index 000000000000..e8bb897782fc > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9306.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/avago,apds9306.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Avago APDS9306 Ambient Light Sensor > + > +maintainers: > + - Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> > + > +description: > + Datasheet at https://docs.broadcom.com/doc/AV02-4755EN > + > +properties: > + compatible: > + const: avago,apds9306 > + > + reg: > + maxItems: 1 > + > + vin-supply: > + description: Regulator supply to the sensor
Why vin? It seems to be vdd on the datasheet. We tend to match the datasheet naming for power supplies as that is normally what is seen on circuit board schematics.
> + > + interrupts: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@52 { > + compatible = "avago,apds9306"; > + reg = <0x52>; > + interrupt-parent = <&gpiof>; > + interrupts = <6 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +...
| |