lkml.org 
[lkml]   [2023]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] media: nuvoton: npcm-video: Fix sleeping in atomic context
Hi Hans,

Thanks for the review.

> > - list = kzalloc(sizeof(*list), GFP_KERNEL);
> > + list = kzalloc(sizeof(*list), GFP_ATOMIC);
> > if (!list)
> > return NULL;
> >
>
> I'm not really sure this is the right approach.
>
> Looking closer at the code I notice that npcm_video_irq is a threaded
> interrupt handler, so wouldn't it be easier to change the video->lock
> spinlock to a mutex?
>

Agree it's better to use mutex. Will send v2 for this.

Regards,
Marvin

\
 
 \ /
  Last update: 2023-10-10 14:32    [W:0.118 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site