Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 10 Oct 2023 14:00:40 +0200 | Subject | Re: [RFC v2 4/5] gpio: add pinctrl based generic gpio driver |
| |
On Thu, Oct 5, 2023 at 4:59 AM AKASHI Takahiro <takahiro.akashi@linaro.org> wrote:
> Some pin controllers provide not only a method to set up lines but > also gpio function. With this commit, a new generic gpio driver will > be provided. It is implemented purely by using pinctrl interfaces. > One of such pin controllers is Arm's SCMI. > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org> > --- > RFC v2 (Oct 5, 2023)
RFC v2 looks very good to me, definitely something that can be merged as a starting point once the hardware has been tested.
> +static int pin_control_gpio_direction_input(struct gpio_chip *chip, > + unsigned int offset) > +{ > + return pinctrl_gpio_direction_input(chip->gpiodev->base + offset); > +} > + > +static int pin_control_gpio_direction_output(struct gpio_chip *chip, > + unsigned int offset, int val) > +{ > + return pinctrl_gpio_direction_output(chip->gpiodev->base + offset); > +}
IIRC Bartosz is working on a patch set getting rid of this kludge having to call with base + offset in every driver, replacing it with generic calls that you can just assign in the gpio_chip.
When this gets applied these changes will likely be in place so you will get rid of this too.
Yours, Linus Walleij
| |