Messages in this thread Patch in this message | | | Date | Tue, 10 Oct 2023 16:42:59 +0800 (CST) | From | <> | Subject | [PATCH linux-next v3 3/4] sched/psi: update rtpoll next update after update triggers and rtpoll total |
| |
From: Yang Yang <yang.yang29@zte.com.cn>
Update group->rtpoll_next_update after called update_triggers() and update rtpoll_total. This will prevent bugs if update_triggers() uses group->rtpoll_next_update in the future, and it makes more sense to set the next update time after we finished the current update.
Signed-off-by: Yang Yang <yang.yang29@zte.com.cn> Suggested-by: Suren Baghdasaryan <surenb@google.com> --- kernel/sched/psi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index 143f8eb34f9d..79f8db0c6150 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -704,12 +704,12 @@ static void psi_rtpoll_work(struct psi_group *group) }
if (now >= group->rtpoll_next_update) { - group->rtpoll_next_update = now + group->rtpoll_min_period; if (changed_states & group->rtpoll_states) { update_triggers(group, now, &update_total, PSI_POLL); memcpy(group->rtpoll_total, group->total[PSI_POLL], sizeof(group->rtpoll_total)); } + group->rtpoll_next_update = now + group->rtpoll_min_period; }
psi_schedule_rtpoll_work(group, -- 2.25.1
| |