Messages in this thread | | | Subject | Re: [PATCH net v3 1/1] ethtool: Fix mod state of verbose no_mask bitset | From | patchwork-bot+netdevbpf@kernel ... | Date | Wed, 11 Oct 2023 03:00:23 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>:
On Mon, 9 Oct 2023 15:36:45 +0200 you wrote: > From: Kory Maincent <kory.maincent@bootlin.com> > > A bitset without mask in a _SET request means we want exactly the bits in > the bitset to be set. This works correctly for compact format but when > verbose format is parsed, ethnl_update_bitset32_verbose() only sets the > bits present in the request bitset but does not clear the rest. The commit > 6699170376ab fixes this issue by clearing the whole target bitmap before we > start iterating. The solution proposed brought an issue with the behavior > of the mod variable. As the bitset is always cleared the old val will > always differ to the new val. > > [...]
Here is the summary with links: - [net,v3,1/1] ethtool: Fix mod state of verbose no_mask bitset https://git.kernel.org/netdev/net/c/108a36d07c01
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |