Messages in this thread | | | Date | Tue, 10 Oct 2023 17:56:28 -0700 | Subject | Re: [PATCH v12 04/10] x86/resctrl: Add comments on RFTYPE flags hierarchy | From | Reinette Chatre <> |
| |
Hi Babu,
On 10/10/2023 4:33 PM, Babu Moger wrote: > resctrl uses RFTYPE flags for creating resctrl directory structure. > > Definitions and directory structures are not documented. Add > comments to improve the readability and help future additions. > > Signed-off-by: Babu Moger <babu.moger@amd.com> > Tested-by: Peter Newman <peternewman@google.com> > Reviewed-by: Peter Newman <peternewman@google.com> > Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com> > Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com> > Reviewed-by: Fenghua Yu <fenghua.yu@intel.com> > Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > --- > v12: Moved the comments from arch/x86/kernel/cpu/resctrl/internal.h > to Documentation/arch/x86/resctrl.rst. (Boris) > ---
It seems like you just copied the text to the documentation without taking into account the destination's use of reST syntax.
I tried a "make htmldocs" to see how this looks but encountered: docutils.utils.SystemMessage: [snip]/linux/Documentation/arch/x86/resctrl.rst:398: (SEVERE/4) Unexpected section title.
Please remove my Reviewed-by.
Reinette
| |