Messages in this thread Patch in this message | | | Date | Sun, 1 Oct 2023 08:20:37 +0200 | From | Greg KH <> | Subject | Re: [PATCH v4 15/15] Drivers: hv: Add modules to expose /dev/mshv to VMMs running on Hyper-V |
| |
On Sat, Sep 30, 2023 at 09:13:07PM +0000, Wei Liu wrote: > On Sat, Sep 30, 2023 at 08:31:13PM +0200, Greg KH wrote: > > On Sat, Sep 30, 2023 at 06:11:19PM +0000, Wei Liu wrote: > > > On Sat, Sep 30, 2023 at 08:11:37AM +0200, Greg KH wrote: > > > > On Fri, Sep 29, 2023 at 11:01:41AM -0700, Nuno Das Neves wrote: > > > > > --- /dev/null > > > > > +++ b/include/uapi/linux/mshv.h > > > > > @@ -0,0 +1,306 @@ > > > > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > > > Much better. > > > > > > > > > +#ifndef _UAPI_LINUX_MSHV_H > > > > > +#define _UAPI_LINUX_MSHV_H > > > > > + > > > > > +/* > > > > > + * Userspace interface for /dev/mshv > > > > > + * Microsoft Hypervisor root partition APIs > > > > > + * NOTE: This API is not yet stable! > > > > > > > > Sorry, that will not work for obvious reasons. > > > > > > This can be removed. For practical purposes, the API has been stable for > > > the past three years. > > > > Then who wrote this text? > > I don't think this matter, does it? This patch series had been rewritten > so many times internally to conform to upstream standard it is very > difficult to track down who wrote this and when.
The point is someone wrote this for a good reason so figuring out why that was done would be good for you all to do as maybe it is true!
> If you have concrete concerns about removing the text, please let me > know.
You need to verify that the comment is not true before removing it, otherwise you all will have a very hard time in the future when things change...
thanks,
greg k-h
| |