Messages in this thread | | | From | Julius Werner <> | Date | Mon, 9 Jan 2023 16:02:26 +0100 | Subject | Re: [PATCH v2] firmware: coreboot: Check size of table entry and split memcpy |
| |
Reviewed-by: Julius Werner <jwerner@chromium.org>
> - memcpy(&device->entry, ptr_entry, entry->size); > + memcpy(device->raw, entry, entry->size);
nit: It's a bit odd to change the source pointer from ptr_entry to entry here. Technically the static analyzer would be within its rights to give you a warning for that as well, because you're now "overrunning" the source struct instead of the destination one.
| |