Messages in this thread | | | Date | Mon, 9 Jan 2023 13:26:04 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH] vsprintf: fix possible NULL pointer deref in vsnprintf() |
| |
On Mon, Jan 09, 2023 at 01:23:40PM +0200, Andy Shevchenko wrote: > On Fri, Jan 06, 2023 at 12:16:31AM +0300, Sergey Shtylyov wrote:
...
> > + /* > > + * C99 allows @buf to be NULL when @size is 0. We treat such NULL as if > > + * @buf pointed to 0-sized buffer, so we can both avoid a NULL pointer > > + * dereference and still return # of characters that would be written > > + * if @buf pointed to a valid buffer... > > + */ > > + if (!buf) > > + size = 0; > > Do we have test cases for that?
This still stays...
> And what's wrong to print "(null)" ? Have you checked if your patch makes any > regressions to those cases?
...but this paragraph is not for the case (I mixed it with the arguments to be NULL).
-- With Best Regards, Andy Shevchenko
| |