Messages in this thread | | | From | Pin-yen Lin <> | Date | Mon, 9 Jan 2023 16:36:00 +0800 | Subject | Re: [PATCH v8 7/9] dt/bindings: display: bridge: it6505: Add mode-switch support |
| |
Hi Krzysztof,
Thanks for your review.
On Sun, Jan 8, 2023 at 10:59 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 07/01/2023 11:22, Pin-yen Lin wrote: > > ITE IT6505 can be used in systems to switch the DP traffic between > > two downstreams, which can be USB Type-C DisplayPort alternate mode > > lane or regular DisplayPort output ports. > > > > Update the binding to accommodate this usage by introducing a > > data-lanes and a mode-switch property on endpoints. > > > > Signed-off-by: Pin-yen Lin <treapking@chromium.org> > > > > --- > > > > Changes in v8: > > - Updated bindings for data-lanes property > > - Fixed subject prefix > > How? It is still wrong. You have slash there.
Sorry, I didn't even notice that. I'll fix this in v9. > > > > > (...) > > > port@1 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > reg = <1>; > > - it6505_out: endpoint { > > + it6505_out: endpoint@0 { > > + reg = <0>; > > remote-endpoint = <&dp_in>; > > data-lanes = <0 1>; > > }; > > @@ -148,3 +173,49 @@ examples: > > }; > > }; > > }; > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + > > + i2c3 { > > Just i2c
I missed this when preparing v8. I'll fix this in v9. > > > Best regards, > Krzysztof >
Best regards, Pin-yen
| |