Messages in this thread | | | Date | Sun, 8 Jan 2023 12:42:28 +0100 | From | Christian Brauner <> | Subject | Re: [PATCH] posix_acl: Use try_cmpxchg in get_acl |
| |
On Fri, Dec 23, 2022 at 11:47:24AM +0100, Christian Brauner wrote: > On Wed, Dec 21, 2022 at 08:35:40PM +0100, Uros Bizjak wrote: > > Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old > > in get_acl. x86 CMPXCHG instruction returns success in ZF flag, > > so this change saves a compare after cmpxchg (and related move > > instruction in front of cmpxchg). > > > > No functional change intended. > > > > Signed-off-by: Uros Bizjak <ubizjak@gmail.com> > > Cc: Christian Brauner <brauner@kernel.org> > > Cc: Alexander Viro <viro@zeniv.linux.org.uk> > > --- > > Looks ok to me. But it's not urgent so I'll circle back to this post > -rc1.
Seems good to me. So if there are no objectsions, then applied, thanks!
[1/1] posix_acl: Use try_cmpxchg in get_acl commit: 4e1da8fe031303599e78f88e0dad9f44272e4f99
| |