lkml.org 
[lkml]   [2023]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v8 04/16] x86/virt/tdx: Add skeleton to initialize TDX on demand
Date
On Fri, 2023-01-06 at 09:14 -0800, Dave Hansen wrote:
> On 12/8/22 22:52, Kai Huang wrote:
> >
> > The TDX module will be initialized in multi-steps defined by the TDX
> > module and most of those steps involve a specific SEAMCALL:
> >
> > 1) Get the TDX module information and TDX-capable memory regions
> > (TDH.SYS.INFO).
> > 2) Build the list of TDX-usable memory regions.
> > 3) Construct a list of "TD Memory Regions" (TDMRs) to cover all
> > TDX-usable memory regions.
> > 4) Pick up one TDX private KeyID as the global KeyID.
> > 5) Configure the TDMRs and the global KeyID to the TDX module
> > (TDH.SYS.CONFIG).
> > 6) Configure the global KeyID on all packages (TDH.SYS.KEY.CONFIG).
> > 7) Initialize all TDMRs (TDH.SYS.TDMR.INIT).
>
> I don't think you really need this *AND* the "TODO" comments in
> init_tdx_module(). Just say:
>
> Add a placeholder tdx_enable() to initialize the TDX module on
> demand. The TODO list will be pared down as functionality is
> added.

Yes agreed. Will do. Thanks.
\
 
 \ /
  Last update: 2023-03-26 23:32    [W:0.066 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site