lkml.org 
[lkml]   [2023]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH HID for-next v1 2/9] selftests: hid: allow to compile hid_bpf with LLVM
    Date
    clang doesn't like to compile a source to the final binary directly:

    clang-14: error: cannot specify -o when generating multiple output files

    So split the final rule in 2, and ensure we compile all dependencies
    before.

    Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    ---
    tools/testing/selftests/hid/Makefile | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests/hid/Makefile
    index f6fc5cfff770..83e8f87d643a 100644
    --- a/tools/testing/selftests/hid/Makefile
    +++ b/tools/testing/selftests/hid/Makefile
    @@ -91,10 +91,6 @@ $(MAKE_DIRS):
    $(call msg,MKDIR,,$@)
    $(Q)mkdir -p $@

    -$(OUTPUT)/%.o: %.c
    - $(call msg,CC,,$@)
    - $(Q)$(CC) $(CFLAGS) -c $(filter %.c,$^) $(LDLIBS) -o $@
    -
    # LLVM's ld.lld doesn't support all the architectures, so use it only on x86
    ifeq ($(SRCARCH),x86)
    LLD := lld
    @@ -223,7 +219,11 @@ $(BPF_SKELS): %.skel.h: %.bpf.o $(BPFTOOL) | $(OUTPUT)
    $(Q)$(BPFTOOL) gen object $(<:.o=.linked1.o) $<
    $(Q)$(BPFTOOL) gen skeleton $(<:.o=.linked1.o) name $(notdir $(<:.bpf.o=)) > $@

    -$(OUTPUT)/%:%.c $(BPF_SKELS) $(KHDR_INCLUDES)/linux/hid.h
    +$(OUTPUT)/%.o: %.c $(BPF_SKELS) $(KHDR_INCLUDES)/linux/hid.h
    + $(call msg,CC,,$@)
    + $(Q)$(CC) $(CFLAGS) -c $(filter %.c,$^) $(LDLIBS) -o $@
    +
    +$(OUTPUT)/%: $(OUTPUT)/%.o
    $(call msg,BINARY,,$@)
    $(Q)$(LINK.c) $^ $(LDLIBS) -o $@

    --
    2.38.1
    \
     
     \ /
      Last update: 2023-03-26 23:29    [W:2.621 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site