lkml.org 
[lkml]   [2023]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable
    Date
    The unprepare sequence has started to fail after moving to panel bridge
    code in the msm drm driver (commit 007ac0262b0d ("drm/msm/dsi: switch to
    DRM_PANEL_BRIDGE")). You'll see messages like this in the kernel logs:

    panel-boe-tv101wum-nl6 ae94000.dsi.0: failed to set panel off: -22

    This is because boe_panel_enter_sleep_mode() needs an operating DSI link
    to set the panel into sleep mode. Performing those writes in the
    unprepare phase of bridge ops is too late, because the link has already
    been torn down by the DSI controller in post_disable, i.e. the PHY has
    been disabled, etc. See dsi_mgr_bridge_post_disable() for more details
    on the DSI .

    Split the unprepare function into a disable part and an unprepare part.
    For now, just the DSI writes to enter sleep mode are put in the disable
    function. This fixes the panel off routine and keeps the panel happy.

    My Wormdingler has an integrated touchscreen that stops responding to
    touch if the panel is only half disabled too. This patch fixes it. And
    finally, this saves power when the screen is off because without this
    fix the regulators for the panel are left enabled when nothing is being
    displayed on the screen.

    Fixes: 007ac0262b0d ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE")
    Fixes: a869b9db7adf ("drm/panel: support for boe tv101wum-nl6 wuxga dsi video mode panel")
    Cc: yangcong <yangcong5@huaqin.corp-partner.google.com>
    Cc: Douglas Anderson <dianders@chromium.org>
    Cc: Jitao Shi <jitao.shi@mediatek.com>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Cc: Rob Clark <robdclark@chromium.org>
    Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
    Signed-off-by: Stephen Boyd <swboyd@chromium.org>
    ---
    drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 16 ++++++++++++----
    1 file changed, 12 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
    index 857a2f0420d7..c924f1124ebc 100644
    --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
    +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
    @@ -1193,14 +1193,11 @@ static int boe_panel_enter_sleep_mode(struct boe_panel *boe)
    return 0;
    }

    -static int boe_panel_unprepare(struct drm_panel *panel)
    +static int boe_panel_disable(struct drm_panel *panel)
    {
    struct boe_panel *boe = to_boe_panel(panel);
    int ret;

    - if (!boe->prepared)
    - return 0;
    -
    ret = boe_panel_enter_sleep_mode(boe);
    if (ret < 0) {
    dev_err(panel->dev, "failed to set panel off: %d\n", ret);
    @@ -1209,6 +1206,16 @@ static int boe_panel_unprepare(struct drm_panel *panel)

    msleep(150);

    + return 0;
    +}
    +
    +static int boe_panel_unprepare(struct drm_panel *panel)
    +{
    + struct boe_panel *boe = to_boe_panel(panel);
    +
    + if (!boe->prepared)
    + return 0;
    +
    if (boe->desc->discharge_on_disable) {
    regulator_disable(boe->avee);
    regulator_disable(boe->avdd);
    @@ -1528,6 +1535,7 @@ static enum drm_panel_orientation boe_panel_get_orientation(struct drm_panel *pa
    }

    static const struct drm_panel_funcs boe_panel_funcs = {
    + .disable = boe_panel_disable,
    .unprepare = boe_panel_unprepare,
    .prepare = boe_panel_prepare,
    .enable = boe_panel_enable,
    base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2
    --
    https://chromeos.dev

    \
     
     \ /
      Last update: 2023-03-26 23:29    [W:5.500 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site