Messages in this thread | | | Date | Wed, 4 Jan 2023 20:50:54 +0100 | Subject | Re: [PATCH v1 4/4] brcmfmac: pcie: Perform correct BCM4364 firmware selection | From | Arend van Spriel <> |
| |
On 1/4/2023 4:56 PM, Aditya Garg wrote: > >> On 04-Jan-2023, at 3:31 PM, Hector Martin <marcan@marcan.st> wrote: >> >> This chip exists in two revisions (B2=r3 and B3=r4) on different >> platforms, and was added without regard to doing proper firmware >> selection or differentiating between them. Fix this to have proper >> per-revision firmwares and support Apple NVRAM selection. >> >> Revision B2 is present on at least these Apple T2 Macs: >> >> kauai: MacBook Pro 15" (Touch/2018-2019) >> maui: MacBook Pro 13" (Touch/2018-2019) >> lanai: Mac mini (Late 2018) >> ekans: iMac Pro 27" (5K, Late 2017) >> >> And these non-T2 Macs: >> >> nihau: iMac 27" (5K, 2019) >> >> Revision B3 is present on at least these Apple T2 Macs: >> >> bali: MacBook Pro 16" (2019) >> trinidad: MacBook Pro 13" (2020, 4 TB3) >> borneo: MacBook Pro 16" (2019, 5600M) >> kahana: Mac Pro (2019) >> kahana: Mac Pro (2019, Rack) >> hanauma: iMac 27" (5K, 2020) >> kure: iMac 27" (5K, 2020, 5700/XT) >> >> Fixes: 24f0bd136264 ("brcmfmac: add the BRCM 4364 found in MacBook Pro 15,2") >> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> >> Signed-off-by: Hector Martin <marcan@marcan.st> >> --- >> .../net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> > > Hi Hector > > Shouldn’t there be a WCC instead of BCA here : > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c?h=v6.2-rc2#n2603
You are right. Thanks for catching that. As Hector is changing that entry he can hopefully take care of it.
Regards, Arend [unhandled content-type:application/pkcs7-signature] | |