Messages in this thread | | | From | Jesus Sanchez-Palencia <> | Date | Wed, 4 Jan 2023 11:33:30 -0800 | Subject | Re: [PATCH] perf: Add missing sys/types.h include |
| |
On Wed, Jan 4, 2023 at 11:13 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > Em Wed, Jan 04, 2023 at 10:23:13AM -0800, Jesus Sanchez-Palencia escreveu: > > Not all libc implementations define ssize_t as part of stdio.h like > > glibc does since the standard only requires this type to be defined by > > unistd.h and sys/types.h. For this reason the perf build is currently > > broken for toolchains based on uClibc, for instance. > > > > Include sys/types.h explicitly to fix that. This is a follow up to > > commit 378ef0f5d9d7 ("perf build: Use libtraceevent from the system"). > > Do you mean this problem started with the 378ef0f5d9d7 commit? If so > then this is the fase for adding: > > Fixes: 378ef0f5d9d7 ("perf build: Use libtraceevent from the system") > > To this patch, ok?
Fixed in v2.
Thanks, Jesus
> > - Arnaldo > > > Signed-off-by: Jesus Sanchez-Palencia <jesussanp@google.com> > > --- > > tools/perf/util/trace-event.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tools/perf/util/trace-event.h b/tools/perf/util/trace-event.h > > index add6c5d9531c..9b3cd79cca12 100644 > > --- a/tools/perf/util/trace-event.h > > +++ b/tools/perf/util/trace-event.h > > @@ -4,6 +4,7 @@ > > > > #include <stdbool.h> > > #include <stdio.h> > > +#include <sys/types.h> > > #include <linux/types.h> > > > > struct evlist; > > -- > > 2.39.0.314.g84b9a713c41-goog > > -- > > - Arnaldo
| |