Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 4 Jan 2023 13:41:22 +0100 | From | Greg KH <> | Subject | Re: [PATCH 4.19 1/1] drm/amdkfd: Check for null pointer after calling kmemdup |
| |
On Tue, Jan 03, 2023 at 08:43:08PM +0200, Dragos-Marian Panait wrote: > From: Jiasheng Jiang <jiasheng@iscas.ac.cn> > > [ Upstream commit abfaf0eee97925905e742aa3b0b72e04a918fa9e ] > > As the possible failure of the allocation, kmemdup() may return NULL > pointer. > Therefore, it should be better to check the 'props2' in order to prevent > the dereference of NULL pointer. > > Fixes: 3a87177eb141 ("drm/amdkfd: Add topology support for dGPUs") > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn> > Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com> > Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> > Signed-off-by: Dragos-Marian Panait <dragos.panait@windriver.com> > --- > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 3 +++ > 1 file changed, 3 insertions(+)
For obvious reasons, I can't take a patch for 4.19.y and not newer kernel releases, right?
Please provide backports for all kernels if you really need to see this merged. And note, it's not a real bug at all, and given that a CVE was allocated for it that makes me want to even more reject it to show the whole folly of that mess.
thanks,
greg k-h
| ![\](/images/icornerr.gif) |