Messages in this thread | ![/](/images/icornerl.gif) | | From | Björn Töpel <> | Subject | Re: [PATCH v5 3/9] riscv/kprobe: Prepare the skeleton to prepare optimized kprobe | Date | Wed, 04 Jan 2023 09:54:28 +0100 |
| |
"liaochang (A)" <liaochang1@huawei.com> writes:
>>> + */ >>> + rel = (unsigned long)slot - (unsigned long)orig->addr; >>> + if (!in_auipc_jalr_range(rel)) { >>> + /* >>> + * Different from x86, we free code buf directly instead >>> of >> >> Reword for readers that are not familiar with x86. > > OK, BTW, i think the code following tag on_error is fairly self-explanatoty, > perhaps this comment is no need anymore.
Fair enough! :-)
Björn
| ![\](/images/icornerr.gif) |