Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 4 Jan 2023 21:34:02 -0600 | From | Samuel Holland <> | Subject | Re: [PATCH] kbuild: readd -w option when vmlinux.o or Module.symver is missing |
| |
On 1/4/23 08:04, Masahiro Yamada wrote: > Commit 63ffe00d8c93 ("kbuild: Fix running modpost with musl libc") > accidentally turned the unresolved symbol warnings into errors when > vmlinux.o (for in-tree builds) or Module.symver (for external module > builds) is missing. > > In those cases, unresolved symbols are expected, but the -w option > is not set because 'missing-input' is referenced before set. > > Move $(missing-input back to the original place. This should be fine > for musl libc because vmlinux.o and -w are not added at the same time. > > With this change, -w may be passed twice, but it is not a big deal. > > Link: https://lore.kernel.org/all/b56a03b8-2a2a-f833-a5d2-cdc50a7ca2bb@cschramm.eu/ > Fixes: 63ffe00d8c93 ("kbuild: Fix running modpost with musl libc") > Reported-by: Christopher Schramm <debian@cschramm.eu> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > scripts/Makefile.modpost | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-)
Sorry for the breakage. This works fine for me, with or without vmlinux.o.
Tested-by: Samuel Holland <samuel@sholland.org>
| ![\](/images/icornerr.gif) |