Messages in this thread | | | Date | Wed, 4 Jan 2023 08:29:47 +0000 | Subject | Re: [PATCH v2] um: vector: Fix memory leak in vector_config | From | Anton Ivanov <> |
| |
On 04/01/2023 08:14, Miaoqian Lin wrote: > kstrdup() return newly allocated copy of the string. > Call kfree() to release the memory when uml_parse_vector_ifspec() fails. > > Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> > --- > changes in v2: > - only call kfree() when uml_parse_vector_ifspec() fails. > --- > arch/um/drivers/vector_kern.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c > index ded7c47d2fbe..131b7cb29576 100644 > --- a/arch/um/drivers/vector_kern.c > +++ b/arch/um/drivers/vector_kern.c > @@ -767,6 +767,7 @@ static int vector_config(char *str, char **error_out) > > if (parsed == NULL) { > *error_out = "vector_config failed to parse parameters"; > + kfree(params); > return -EINVAL; > } >
Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>
-- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/
| |