Messages in this thread | | | Date | Tue, 31 Jan 2023 13:14:00 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2 0/6] arm64/signal: Signal handling cleanups |
| |
On Tue, Jan 31, 2023 at 12:51:33PM +0000, Catalin Marinas wrote: > On Tue, Jan 03, 2023 at 08:25:15PM +0000, Mark Brown wrote:
> > arm64/signal: Avoid rereading context frame sizes > > arm64/signal: Only read new data when parsing the SVE context > > arm64/signal: Only read new data when parsing the ZA context
> I'm not sure these add much to the code readability (and the performance > improvement I guess is negligible). We avoid some copy_from_user() into > the context structures but rely on data read previously or some > get_user() into local variables. Personally I'd make the > restore_fpsimd_context() also do a copy_from_user() for consistency with > the current sve and za frames restoring.
> Personal preference, not sure whether Will has the same view.
I don't particularly care about those changs either, Will seemed to be asking for something like that.
Note that I should at some point today send a version of this series rebased on for-next/core due to the TPIDR2 and SME2 changes. [unhandled content-type:application/pgp-signature] | |