Messages in this thread | | | Subject | Re: [PATCH net] net: ethernet: mtk_eth_soc: disable hardware DSA untagging for second MAC | From | Paolo Abeni <> | Date | Tue, 31 Jan 2023 14:00:43 +0100 |
| |
On Sat, 2023-01-28 at 12:42 +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > According to my tests on MT7621AT and MT7623NI SoCs, hardware DSA untagging > won't work on the second MAC. Therefore, disable this feature when the > second MAC of the MT7621 and MT7623 SoCs is being used. > > Fixes: 2d7605a72906 ("net: ethernet: mtk_eth_soc: enable hardware DSA untagging") > Link: https://lore.kernel.org/netdev/6249fc14-b38a-c770-36b4-5af6d41c21d3@arinc9.com/ > Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com> > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > > Final send which should end up on the list. I tested this with Felix's > upcoming patch series. This fix is still needed on top of it. > > https://lore.kernel.org/netdev/20221230073145.53386-1-nbd@nbd.name/ > > The MTK_GMAC1_TRGMII capability is only on the MT7621 and MT7623 SoCs which > I see this problem on. I'm new to coding so I took an educated guess from > the use of MTK_NETSYS_V2 to disable this feature altogether for MT7986 SoC.
Keeping this one a little more on pw. It would be great is someone else could validate the above on the relevant H/W.
Thanks,
Paolo
| |