lkml.org 
[lkml]   [2023]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] libata: clean up some inconsistent indenting
From
Date
On 1/31/23 2:26 PM, Damien Le Moal wrote:
[...]
>> No functional modification involved.
>>
>> drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting.
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3905
>> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>> ---
>> drivers/ata/pata_serverworks.c | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/ata/pata_serverworks.c b/drivers/ata/pata_serverworks.c
>> index c0bc4af0d196..c6bd9e95d4e8 100644
>> --- a/drivers/ata/pata_serverworks.c
>> +++ b/drivers/ata/pata_serverworks.c
>> @@ -434,10 +434,9 @@ static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id
>> (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
>> (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
>>
>> - /* If the returned btr is the newer revision then
>> - select the right info block */
>> - if (rc == 3)
>> - ppi[0] = &info[3];
>> + /* If the returned btr is the newer revision then select the right info block */
>
> Very long line. Please make that a proper multi-line comment.

Perhaps the material of a separate patch?

> And the patch title should be:
>
> ata: pata_serverworks: clean up indentation

Yes!

[...]

MBR, Sergey

\
 
 \ /
  Last update: 2023-03-27 00:03    [W:0.057 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site