Messages in this thread | | | From | Willem de Bruijn <> | Date | Tue, 31 Jan 2023 16:53:24 -0500 | Subject | Re: [PATCH net-next v3 3/4] selftests: net: udpgso_bench: Fix racing bug between the rx/tx programs |
| |
On Tue, Jan 31, 2023 at 3:56 PM Andrei Gherzan <andrei.gherzan@canonical.com> wrote: > > "udpgro_bench.sh" invokes udpgso_bench_rx/udpgso_bench_tx programs > subsequently and while doing so, there is a chance that the rx one is not > ready to accept socket connections. This racing bug could fail the test > with at least one of the following: > > ./udpgso_bench_tx: connect: Connection refused > ./udpgso_bench_tx: sendmsg: Connection refused > ./udpgso_bench_tx: write: Connection refused > > This change addresses this by making udpgro_bench.sh wait for the rx > program to be ready before firing off the tx one - up to a 10s timeout. > > Fixes: 3a687bef148d ("selftests: udp gso benchmark") > Signed-off-by: Andrei Gherzan <andrei.gherzan@canonical.com> > CC: Paolo Abeni <pabeni@redhat.com> > CC: Willem de Bruijn <willemb@google.com>
Same point on fixes to net instead of net-next.
Aside from that, looks good. Neat solution. Thanks for the suggestion, Paolo.
Reviewed-by: Willem de Bruijn <willemb@google.com>
| |