Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [PATCH 3/7] x86/resctrl: Add a new node-scoped resource to rdt_resources_all[] | Date | Mon, 30 Jan 2023 19:04:28 +0000 |
| |
>> + .domains = domain_init(RDT_RESOURCE_NODE), >> + .fflags = RFTYPE_RES_MB,
> RFTYPE_RES_MB is for the resource to add some files in info/MB. > But the NODE resource doesn't have any files to show in info/MB. > > Only shown file for the NODE resource is info/L3_MON/snc_ways. But this > file doesn't need to set fflags. > > Seems no need to set fflags or fflags=0 to eliminate confusion?
I just cut & pasted from the L3 ... oops. I think you may be right that an explicit ".fflags = 0" would be best here.
-Tony
| |