Messages in this thread | | | From | Pasha Tatashin <> | Date | Mon, 30 Jan 2023 12:19:58 -0500 | Subject | Re: [PATCH] mm: extend max struct page size for kmsan |
| |
On Mon, Jan 30, 2023 at 8:07 AM Arnd Bergmann <arnd@kernel.org> wrote: > > From: Arnd Bergmann <arnd@arndb.de> > > After x86 has enabled support for KMSAN, it has become possible > to have larger 'struct page' than was expected when commit > 5470dea49f53 ("mm: use mm_zero_struct_page from SPARC on all 64b > architectures") was merged: > > include/linux/mm.h:156:10: warning: no case matching constant switch condition '96' > switch (sizeof(struct page)) { > > Extend the maximum accordingly. > > Fixes: 5470dea49f53 ("mm: use mm_zero_struct_page from SPARC on all 64b architectures")
No need to add the above "Fixes:". The above patch works as expected everywhere where the struct page is 80 bytes or smaller (as specified by the comment).
I also agree with others that the KMSAN should be part of page_ext instead of increasing the complexity of "struct page".
Otherwise, Reviewed-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Thanks, Pasha
| |