Messages in this thread | | | From | Brian Cain <> | Subject | RE: [PATCH] trap: Fix warning comparing pointer to 0 | Date | Mon, 30 Jan 2023 16:43:15 +0000 |
| |
> -----Original Message----- > From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> ... > > Avoid pointer type value compared with 0 to make code clear. > > ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3860 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > arch/hexagon/kernel/traps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c > index 6447763ce5a9..fdbbf78b4ce0 100644 > --- a/arch/hexagon/kernel/traps.c > +++ b/arch/hexagon/kernel/traps.c > @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task, > unsigned long *fp, > } > > /* Attempt to continue past exception. */ > - if (0 == newfp) { > + if (!newfp) { > struct pt_regs *regs = (struct pt_regs *) (((void *)fp) > + 8); > > -- > 2.20.1.7.g153144c
Acked-by: Brian Cain <bcain@quicinc.com>
| |