Messages in this thread | | | Date | Mon, 30 Jan 2023 17:31:04 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH v5 net-next 00/13] add support for the the vsc7512 internal copper phys |
| |
On Fri, Jan 27, 2023 at 11:35:46AM -0800, Colin Foster wrote: > This patch series is a continuation to add support for the VSC7512: > https://patchwork.kernel.org/project/netdevbpf/list/?series=674168&state=* > > That series added the framework and initial functionality for the > VSC7512 chip. Several of these patches grew during the initial > development of the framework, which is why v1 will include changelogs. > It was during v9 of that original MFD patch set that these were dropped. > > With that out of the way, the VSC7512 is mainly a subset of the VSC7514 > chip. The 7512 lacks an internal MIPS processor, but otherwise many of > the register definitions are identical. That is why several of these > patches are simply to expose common resources from > drivers/net/ethernet/mscc/*. > > This patch only adds support for the first four ports (swp0-swp3). The > remaining ports require more significant changes to the felix driver, > and will be handled in the future.
For the whole series:
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com> Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com> # regression
A minor nitpick after this is merged: please clean up and unexport stuff from include/soc/mscc/vsc7514_regs.h which was added with your previous approaches and then we steered mid-way.
Congratulations!
| |