Messages in this thread | | | Date | Mon, 30 Jan 2023 10:59:32 -0400 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v2 2/3] iommufd/device: Make hwpt_list list_add/del symmetric |
| |
On Sat, Jan 28, 2023 at 01:18:10PM -0800, Nicolin Chen wrote: > Since the list_del() of hwpt_item is done in iommufd_device_detach(), move > its list_add_tail() to a similar place in iommufd_device_do_attach(). > > Also move and place the mutex outside the iommufd_device_auto_get_domain() > and iommufd_device_do_attach() calls, to serialize attach/detach routines. > This adds an additional locking protection so that the following patch can > safely remove devices_lock.
That should be two patches then, this is just moving one line of code from what I can tell?
Jason
| |