Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Mon, 30 Jan 2023 15:36:04 +0100 | Subject | Re: [PATCH v2 08/11] driver core: fw_devlink: Make cycle detection more robust |
| |
Hi Andy,
On Mon, Jan 30, 2023 at 1:16 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Fri, Jan 27, 2023 at 11:34:28PM -0800, Saravana Kannan wrote: > > On Fri, Jan 27, 2023 at 1:43 AM Andy Shevchenko > > <andriy.shevchenko@linux.intel.com> wrote: > > > On Thu, Jan 26, 2023 at 04:11:35PM -0800, Saravana Kannan wrote: > > > > +static bool __fw_devlink_relax_cycles(struct device *con, > > > > + struct fwnode_handle *sup_handle) > > > > +{ > > > > + struct fwnode_link *link; > > > > + struct device_link *dev_link; > > > > > > > + struct device *sup_dev = NULL, *par_dev = NULL; > > > > > > You can put it the first line since it's long enough. > > > > Wait, is that a style guideline to have the longer lines first? > > No, but it's easier to read.
Yes it is, "reverse xmas tree" local variable ordering: https://elixir.bootlin.com/linux/v6.2-rc6/source/Documentation/process/maintainer-netdev.rst#L272
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |