lkml.org 
[lkml]   [2023]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory overlap with SMEM region
Hi Jamie,

On Sat, 28 Jan 2023 at 06:53, Jamie Douglass <jamiemdouglass@gmail.com> wrote:
>
> A previously committed reserved memory region was overlapping with the

IMHO there should be marked commit which you're fixing:
Fixes: 22c7e1a0fa45 ("arm64: dts: msm8992-bullhead: add memory hole region")

> SMEM memory region, causing an error message in dmesg:
> OF: reserved mem: OVERLAP DETECTED!
> reserved@5000000 (0x0000000005000000--0x0000000007200000)
> overlaps with smem_region@6a00000
> (0x0000000006a00000--0x0000000006c00000)
> This patch splits the previous reserved memory region into two
> reserved sections either side of the SMEM memory region.

Reviewed-by: Petr Vorel <pvorel@suse.cz>
Tested-by: Petr Vorel <pvorel@suse.cz>
...
> +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> @@ -53,8 +53,13 @@ cont_splash_mem: memory@3400000 {
> no-map;
> };
>
> - removed_region: reserved@5000000 {
> - reg = <0 0x05000000 0 0x2200000>;
> + reserved@5000000 {
Can we keep "removed_region:" ?
removed_region: reserved@5000000 {

> + reg = <0x0 0x05000000 0x0 0x1a00000>;
> + no-map;
> + };
> +
> + reserved@6c00000 {
Not sure which label to add, maybe append 2?
removed_region2: reserved@6c00000 {
@Konrad @Krzysztof WDYT?

Kind regards,
Petr

> + reg = <0x0 0x06c00000 0x0 0x400000>;
> no-map;
> };
> };

\
 
 \ /
  Last update: 2023-03-27 00:02    [W:0.043 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site