Messages in this thread | | | From | Жандарович Никита Игоре вич <> | Subject | RE: [PATCH 5.10 1/1] mt76: fix mt7615_init_tx_queues() return value | Date | Mon, 30 Jan 2023 13:48:24 +0000 |
| |
> On Mon, Jan 30, 2023 at 01:27:26PM +0000, Жандарович Никита Игоревич > wrote: > > > What is the git commit id of this upstream? > > > > > > And I can't apply this as-is for the obvious reason it would mess up > > > the changelog, how did you create this? > > > > > > confused, > > > > > > greg k-h > > > > Commit in question is b671da33d1c5973f90f098ff66a91953691df582 > > upstream. I wasn't certain it makes sense to backport the whole patch > > as only a small portion of it pertains to the fault at question. > > What is the "fault"?
In 5.10.y "mt7615_init_tx_queues() returns 0 regardless of how final mt7615_init_tx_queue() performs. If mt7615_init_tx_queue() fails (due to memory issues, for instance), parent function will still erroneously return 0."
This was fixed upstream, although that particular commit's scope was broader.
> And why not take the whole thing? What's wrong with that? We almost > always want to take whatever is in Linus's tree because when we do not, we > almost always cause bugs or other problems (later merge issues.) > > So always take the original fix please. > > thanks, > > greg k-h
That makes sense, of course. Thanks for your patience, will work toward backporting the whole thing.
regards,
Nikita
| |