Messages in this thread | | | From | Tomasz Duszynski <> | Subject | RE: [PATCH] vfio: platform: ignore missing reset if disabled at module init | Date | Mon, 30 Jan 2023 12:31:11 +0000 |
| |
>-----Original Message----- >From: Tian, Kevin <kevin.tian@intel.com> >Sent: Monday, January 30, 2023 10:06 AM >To: Tomasz Duszynski <tduszynski@marvell.com>; Eric Auger <eric.auger@redhat.com>; Alex Williamson ><alex.williamson@redhat.com>; Cornelia Huck <cohuck@redhat.com>; Jason Gunthorpe <jgg@ziepe.ca>; >open list:VFIO PLATFORM DRIVER <kvm@vger.kernel.org>; open list <linux-kernel@vger.kernel.org> >Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com> >Subject: [EXT] RE: [PATCH] vfio: platform: ignore missing reset if disabled at module init > >External Email > >---------------------------------------------------------------------- >> From: Tomasz Duszynski <tduszynski@marvell.com> >> Sent: Thursday, January 26, 2023 12:11 AM @@ -653,7 +653,8 @@ int >> vfio_platform_init_common(struct vfio_platform_device *vdev) >> if (ret && vdev->reset_required) >> dev_err(dev, "No reset function found for device %s\n", >> vdev->name); >> - return ret; >> + >> + return vdev->reset_required ? ret : 0; >> } >> EXPORT_SYMBOL_GPL(vfio_platform_init_common); > >It reads slightly better to me as below: > > if (ret & vdev->reset_required) { > dev_err(...); > return ret; > } > > return 0;
Sure no problem.
| |