lkml.org 
[lkml]   [2023]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 1/1] dmaengine: Make an order in struct dma_device definition
    Date
    Make an order in struct dma_device:
    - added missing kernel doc descriptions
    - put descriptions in the order of appearance in the code
    - updated indentation where it makes sense

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    include/linux/dmaengine.h | 13 +++++++------
    1 file changed, 7 insertions(+), 6 deletions(-)

    diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
    index 0c020682d894..c3656e590213 100644
    --- a/include/linux/dmaengine.h
    +++ b/include/linux/dmaengine.h
    @@ -773,6 +773,7 @@ struct dma_filter {

    /**
    * struct dma_device - info on the entity supplying DMA services
    + * @ref: reference is taken and put every time a channel is allocated or freed
    * @chancnt: how many DMA channels are supported
    * @privatecnt: how many DMA channels are requested by dma_request_channel
    * @channels: the list of struct dma_chan
    @@ -789,6 +790,7 @@ struct dma_filter {
    * @dev_id: unique device ID
    * @dev: struct device reference for dma mapping api
    * @owner: owner module (automatically set based on the provided dev)
    + * @chan_ida: unique channel ID
    * @src_addr_widths: bit mask of src addr widths the device supports
    * Width is specified in bytes, e.g. for a device supporting
    * a width of 4 the mask should have BIT(4) set.
    @@ -802,6 +804,7 @@ struct dma_filter {
    * @max_sg_burst: max number of SG list entries executed in a single burst
    * DMA tansaction with no software intervention for reinitialization.
    * Zero value means unlimited number of entries.
    + * @descriptor_reuse: a submitted transfer can be resubmitted after completion
    * @residue_granularity: granularity of the transfer residue reported
    * by tx_status
    * @device_alloc_chan_resources: allocate resources and return the
    @@ -839,7 +842,6 @@ struct dma_filter {
    * struct with auxiliary transfer status information, otherwise the call
    * will just return a simple status code
    * @device_issue_pending: push pending transactions to hardware
    - * @descriptor_reuse: a submitted transfer can be resubmitted after completion
    * @device_release: called sometime atfer dma_async_device_unregister() is
    * called and there are no further references to this structure. This
    * must be implemented to free resources however many existing drivers
    @@ -847,6 +849,7 @@ struct dma_filter {
    * @dbg_summary_show: optional routine to show contents in debugfs; default code
    * will be used when this is omitted, but custom code can show extra,
    * controller specific information.
    + * @dbg_dev_root: the root folder in debugfs for this device
    */
    struct dma_device {
    struct kref ref;
    @@ -855,7 +858,7 @@ struct dma_device {
    struct list_head channels;
    struct list_head global_node;
    struct dma_filter filter;
    - dma_cap_mask_t cap_mask;
    + dma_cap_mask_t cap_mask;
    enum dma_desc_metadata_mode desc_metadata_modes;
    unsigned short max_xor;
    unsigned short max_pq;
    @@ -924,10 +927,8 @@ struct dma_device {
    struct dma_chan *chan, dma_addr_t dst, u64 data,
    unsigned long flags);

    - void (*device_caps)(struct dma_chan *chan,
    - struct dma_slave_caps *caps);
    - int (*device_config)(struct dma_chan *chan,
    - struct dma_slave_config *config);
    + void (*device_caps)(struct dma_chan *chan, struct dma_slave_caps *caps);
    + int (*device_config)(struct dma_chan *chan, struct dma_slave_config *config);
    int (*device_pause)(struct dma_chan *chan);
    int (*device_resume)(struct dma_chan *chan);
    int (*device_terminate_all)(struct dma_chan *chan);
    --
    2.39.0
    \
     
     \ /
      Last update: 2023-03-27 00:01    [W:2.892 / U:0.432 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site