Messages in this thread | | | Date | Mon, 30 Jan 2023 17:01:17 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] crypto: arm64/sm4 - Fix possible crash in GCM cryption |
| |
On Mon, Jan 30, 2023 at 04:15:33PM +0800, Herbert Xu wrote: > > Actually I think there is a serious bug here. If you're doing an > empty message, you must not call skcipher_walk_done as that may > then free random uninitialised stack memory.
Hah, I had forgotten that this thread started with your patch to fix this exact bug :)
Could you confirm that you did copy this from ccm?
It would be nice if you could rewrite your loop in a form similar to my patch to ccm.
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |