Messages in this thread | | | From | Thomas Winter <> | Subject | Re: [PATCH v4 1/2] ip/ip6_gre: Fix changing addr gen mode not generating IPv6 link local address | Date | Tue, 31 Jan 2023 03:32:55 +0000 |
| |
On Sun, 2023-01-29 at 11:14 -0700, David Ahern wrote: > A couple of nits. > > On 1/26/23 7:59 PM, Thomas Winter wrote: > > diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > > index f7a84a4acffc..0065b38fc85b 100644 > > --- a/net/ipv6/addrconf.c > > +++ b/net/ipv6/addrconf.c > > @@ -3355,7 +3355,7 @@ static void addrconf_addr_gen(struct > > inet6_dev *idev, bool prefix_route) > > } > > } > > > > -static void addrconf_dev_config(struct net_device *dev) > > +static void addrconf_eth_config(struct net_device *dev) > > why the rename of this function? It does more than ethernet config.
A remnant of a previous version where I named the new function addrconf_dev_config which then calls addrconf_eth_config, addrconf_gre_config, etc.
There is also the following comment in the function "Alas, we support only Ethernet autoconfiguration.".
I could rename it back in the next patchset version.
> > > > { > > struct inet6_dev *idev; > > > > @@ -3447,6 +3447,30 @@ static void addrconf_gre_config(struct > > net_device *dev) > > } > > #endif > > > > +static void addrconfig_init_auto_addrs(struct net_device *dev) > > this one should be 'addrconf_' to be consistent with related function > names. > >
Will update in new patch set.
| |