Messages in this thread | | | Date | Fri, 27 Jan 2023 14:56:46 +0100 | Subject | Re: [PATCH v2 2/4] arm64: dts: qcom: sm6350: Add camera clock controller | From | Konrad Dybcio <> |
| |
On 27.01.2023 14:54, Bryan O'Donoghue wrote: > On 27/01/2023 13:11, Luca Weiss wrote: >>> Doh I meant to say a power-domain to an mmcx a la >>> >>> power-domains = <&rpmhpd SM8250_MMCX>; >>> required-opps = <&rpmhpd_opp_low_svs>; >>> >>> TITAN_TOP should be in your cci and camss dt nodes. >> Okay, that makes more sense. >> >> What I don't quite understand is why sm8250 only has MMCX listed there >> since downstream has both vdd_mx-supply = <&VDD_MX_LEVEL> and >> vdd_mm-supply = <&VDD_MMCX_LEVEL> and both "supplies" are used for >> different clocks using .vdd_class > > power-domains = <&rpmhpd SM8250_MMCX>; == MMCX_LEVEL required for camcc > power-domains = <&camcc TITAN_TOP_GDSC>; required for cci/camss > > now that you ask the question about MX_LEVEL you're making me doubt we have a 100% complete representation upstream TB perfectly honest, warrants a deep dive.. > > I just remember that on 8250 we tripped over MMCX not being switched on when - display I think was switched off. There's no MMCX on 6350 and MX is a parent of CX, so if we just stick CX here and add the lowest level to required-opps and add corresponding PM ops to the clk driver, it'll all be taken care of!
Konrad
> > --- > bod >
| |