lkml.org 
[lkml]   [2023]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 13/37] nvmem: core: move struct nvmem_cell_info to nvmem-provider.h
    Date
    From: Michael Walle <michael@walle.cc>

    struct nvmem_cell_info is used to describe a cell. Thus this should
    really be in the nvmem-provider's header. There are two (unused) nvmem
    access methods which use the nvmem_cell_info to describe the cell to be
    accesses. One can argue, that they will create a cell before accessing,
    thus they are both a provider and a consumer.

    struct nvmem_cell_info will get used more and more by nvmem-providers,
    don't force them to also include the consumer header, although they are
    not.

    Signed-off-by: Michael Walle <michael@walle.cc>
    Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    ---
    include/linux/nvmem-consumer.h | 10 +---------
    include/linux/nvmem-provider.h | 19 ++++++++++++++++++-
    2 files changed, 19 insertions(+), 10 deletions(-)

    diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consumer.h
    index 980f9c9ac0bc..1f62f7ba71ca 100644
    --- a/include/linux/nvmem-consumer.h
    +++ b/include/linux/nvmem-consumer.h
    @@ -18,15 +18,7 @@ struct device_node;
    /* consumer cookie */
    struct nvmem_cell;
    struct nvmem_device;
    -
    -struct nvmem_cell_info {
    - const char *name;
    - unsigned int offset;
    - unsigned int bytes;
    - unsigned int bit_offset;
    - unsigned int nbits;
    - struct device_node *np;
    -};
    +struct nvmem_cell_info;

    /**
    * struct nvmem_cell_lookup - cell lookup entry
    diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
    index 55181d837969..a953a3a59535 100644
    --- a/include/linux/nvmem-provider.h
    +++ b/include/linux/nvmem-provider.h
    @@ -14,7 +14,6 @@
    #include <linux/gpio/consumer.h>

    struct nvmem_device;
    -struct nvmem_cell_info;
    typedef int (*nvmem_reg_read_t)(void *priv, unsigned int offset,
    void *val, size_t bytes);
    typedef int (*nvmem_reg_write_t)(void *priv, unsigned int offset,
    @@ -47,6 +46,24 @@ struct nvmem_keepout {
    unsigned char value;
    };

    +/**
    + * struct nvmem_cell_info - NVMEM cell description
    + * @name: Name.
    + * @offset: Offset within the NVMEM device.
    + * @bytes: Length of the cell.
    + * @bit_offset: Bit offset if cell is smaller than a byte.
    + * @nbits: Number of bits.
    + * @np: Optional device_node pointer.
    + */
    +struct nvmem_cell_info {
    + const char *name;
    + unsigned int offset;
    + unsigned int bytes;
    + unsigned int bit_offset;
    + unsigned int nbits;
    + struct device_node *np;
    +};
    +
    /**
    * struct nvmem_config - NVMEM device configuration
    *
    --
    2.25.1
    \
     
     \ /
      Last update: 2023-03-26 23:58    [W:5.105 / U:0.148 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site