lkml.org 
[lkml]   [2023]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 6/8] ARM: dts: exynos: move DP and MIPI phys to PMU node in Exynos5420
From
On 27.01.2023 20:40, Krzysztof Kozlowski wrote:
> The DisplayPort and MIPI phys are actually part of the Power Management
> Unit system controller. They do not have their own address space, thus
> keeping the nodes under soc causes warnings:
>
> exynos5420-smdk5420.dtb: soc: dp-video-phy: {'compatible': ['samsung,exynos5420-dp-video-phy'],
> 'samsung,pmu-syscon': [[11]], '#phy-cells': [[0]], 'phandle': [[16]]} should not be valid under {'type': 'object'}
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos5420.dtsi | 24 +++++++++++-------------
> 1 file changed, 11 insertions(+), 13 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index b1051a7d07af..6cdb1a832fb9 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -585,18 +585,6 @@ spi_2: spi@12d40000 {
> status = "disabled";
> };
>
> - dp_phy: dp-video-phy {
> - compatible = "samsung,exynos5420-dp-video-phy";
> - samsung,pmu-syscon = <&pmu_system_controller>;
> - #phy-cells = <0>;
> - };
> -
> - mipi_phy: mipi-video-phy {
> - compatible = "samsung,exynos5420-mipi-video-phy";
> - syscon = <&pmu_system_controller>;
> - #phy-cells = <1>;
> - };
> -
> dsi: dsi@14500000 {
> compatible = "samsung,exynos5410-mipi-dsi";
> reg = <0x14500000 0x10000>;
> @@ -822,7 +810,7 @@ jpeg_1: jpeg@11f60000 {
> };
>
> pmu_system_controller: system-controller@10040000 {
> - compatible = "samsung,exynos5420-pmu", "syscon";
> + compatible = "samsung,exynos5420-pmu", "simple-mfd", "syscon";
> reg = <0x10040000 0x5000>;
> clock-names = "clkout16";
> clocks = <&clock CLK_FIN_PLL>;
> @@ -830,6 +818,16 @@ pmu_system_controller: system-controller@10040000 {
> interrupt-controller;
> #interrupt-cells = <3>;
> interrupt-parent = <&gic>;
> +
> + dp_phy: dp-phy {
> + compatible = "samsung,exynos5420-dp-video-phy";
> + #phy-cells = <0>;
> + };
> +
> + mipi_phy: mipi-phy {
> + compatible = "samsung,exynos5420-mipi-video-phy";
> + #phy-cells = <1>;
> + };
> };
>
> tmu_cpu0: tmu@10060000 {

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland

\
 
 \ /
  Last update: 2023-03-27 00:00    [W:0.174 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site