lkml.org 
[lkml]   [2023]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v12 2/6] dt-bindings: thermal: mediatek: Add LVTS thermal controllers dt-binding definition
    From

    Hi Rob,

    I think Balsam took into account your comments. Is it fine for you ?


    On 26/01/2023 17:10, bchihi@baylibre.com wrote:
    > From: Balsam CHIHI <bchihi@baylibre.com>
    >
    > Add LVTS thermal controllers dt-binding definition for mt8195.
    >
    > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
    > ---
    > Changelog:
    > v12:
    > - Fixed subject prefix
    > - Fixed licences GPL-2.0+ to GPL-2.0
    > - Added dual licenses
    > v11:
    > - Rebase on top of "thermal/linux-next" :
    > base=0d568e144ead70189e7f16066dcb155b78ff9266
    > - Remove unsupported SoC (mt8192) from dt-binding definition
    > v10:
    > - Rebase on top of "thermal/linux-next" : thermal-v6.3-rc1
    > v9:
    > - Rebase on top of 6.0.0-rc1
    > - Update dt-bindings :
    > - Add "allOf:if:then:"
    > - Use mt8192 as example (instead of mt8195)
    > - Fix dt-binding errors
    > - Fix DTS errors
    > v8:
    > - Fix coding style issues
    > - Rebase on top of next-20220803
    > - Add multi-instance support :
    > - Rewrite DT-binding and DTS :
    > - Add DT-binding and DTS for LVTS_v4 (MT8192 and MT8195)
    > - One LVTS node for each HW Domain (AP and MCU)
    > - One SW Instance for each HW Domain
    > v7:
    > - Fix coding style issues
    > - Rewrite dt bindings
    > - was not accurate
    > - Use mt8195 for example (instead of mt8192)
    > - Rename mt6873 to mt8192
    > - Remove clock name
    > ---
    > ---
    > .../thermal/mediatek,lvts-thermal.yaml | 107 ++++++++++++++++++
    > include/dt-bindings/thermal/mediatek-lvts.h | 19 ++++
    > 2 files changed, 126 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
    > create mode 100644 include/dt-bindings/thermal/mediatek-lvts.h
    >
    > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
    > new file mode 100644
    > index 000000000000..12bfbdd8ff89
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
    > @@ -0,0 +1,107 @@
    > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
    > +%YAML 1.2
    > +---
    > +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
    > +$schema: http://devicetree.org/meta-schemas/core.yaml#
    > +
    > +title: MediaTek SoC Low Voltage Thermal Sensor (LVTS)
    > +
    > +maintainers:
    > + - Balsam CHIHI <bchihi@baylibre.com>
    > +
    > +description: |
    > + LVTS is a thermal management architecture composed of three subsystems,
    > + a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU),
    > + a Converter - Low Voltage Thermal Sensor converter (LVTS), and
    > + a Digital controller (LVTS_CTRL).
    > +
    > +properties:
    > + compatible:
    > + enum:
    > + - mediatek,mt8195-lvts-ap
    > + - mediatek,mt8195-lvts-mcu
    > +
    > + reg:
    > + maxItems: 1
    > +
    > + interrupts:
    > + maxItems: 1
    > +
    > + clocks:
    > + maxItems: 1
    > +
    > + resets:
    > + maxItems: 1
    > + description: LVTS reset for clearing temporary data on AP/MCU.
    > +
    > + nvmem-cells:
    > + minItems: 1
    > + items:
    > + - description: Calibration eFuse data 1 for LVTS
    > + - description: Calibration eFuse data 2 for LVTS
    > +
    > + nvmem-cell-names:
    > + minItems: 1
    > + items:
    > + - const: lvts-calib-data-1
    > + - const: lvts-calib-data-2
    > +
    > + "#thermal-sensor-cells":
    > + const: 1
    > +
    > +required:
    > + - compatible
    > + - reg
    > + - interrupts
    > + - clocks
    > + - resets
    > + - nvmem-cells
    > + - nvmem-cell-names
    > + - "#thermal-sensor-cells"
    > +
    > +additionalProperties: false
    > +
    > +examples:
    > + - |
    > + #include <dt-bindings/interrupt-controller/arm-gic.h>
    > + #include <dt-bindings/clock/mt8195-clk.h>
    > + #include <dt-bindings/reset/mt8195-resets.h>
    > + #include <dt-bindings/thermal/mediatek-lvts.h>
    > +
    > + soc {
    > + #address-cells = <2>;
    > + #size-cells = <2>;
    > +
    > + lvts_mcu: thermal-sensor@11278000 {
    > + compatible = "mediatek,mt8195-lvts-mcu";
    > + reg = <0 0x11278000 0 0x1000>;
    > + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>;
    > + clocks = <&infracfg_ao CLK_INFRA_AO_THERM>;
    > + resets = <&infracfg_ao MT8195_INFRA_RST4_THERM_CTRL_MCU_SWRST>;
    > + nvmem-cells = <&lvts_efuse_data1 &lvts_efuse_data2>;
    > + nvmem-cell-names = "lvts-calib-data-1", "lvts-calib-data-2";
    > + #thermal-sensor-cells = <1>;
    > + };
    > + };
    > +
    > + thermal_zones: thermal-zones {
    > + cpu0-thermal {
    > + polling-delay = <1000>;
    > + polling-delay-passive = <250>;
    > + thermal-sensors = <&lvts_mcu MT8195_MCU_LITTLE_CPU0>;
    > +
    > + trips {
    > + cpu0_alert: trip-alert {
    > + temperature = <85000>;
    > + hysteresis = <2000>;
    > + type = "passive";
    > + };
    > +
    > + cpu0_crit: trip-crit {
    > + temperature = <100000>;
    > + hysteresis = <2000>;
    > + type = "critical";
    > + };
    > + };
    > + };
    > + };
    > diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h
    > new file mode 100644
    > index 000000000000..902d5b1e4f43
    > --- /dev/null
    > +++ b/include/dt-bindings/thermal/mediatek-lvts.h
    > @@ -0,0 +1,19 @@
    > +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */
    > +/*
    > + * Copyright (c) 2023 MediaTek Inc.
    > + * Author: Balsam CHIHI <bchihi@baylibre.com>
    > + */
    > +
    > +#ifndef __MEDIATEK_LVTS_DT_H
    > +#define __MEDIATEK_LVTS_DT_H
    > +
    > +#define MT8195_MCU_BIG_CPU0 0
    > +#define MT8195_MCU_BIG_CPU1 1
    > +#define MT8195_MCU_BIG_CPU2 2
    > +#define MT8195_MCU_BIG_CPU3 3
    > +#define MT8195_MCU_LITTLE_CPU0 4
    > +#define MT8195_MCU_LITTLE_CPU1 5
    > +#define MT8195_MCU_LITTLE_CPU2 6
    > +#define MT8195_MCU_LITTLE_CPU3 7
    > +
    > +#endif /* __MEDIATEK_LVTS_DT_H */

    --
    <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

    Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
    <http://twitter.com/#!/linaroorg> Twitter |
    <http://www.linaro.org/linaro-blog/> Blog

    \
     
     \ /
      Last update: 2023-03-27 00:00    [W:4.089 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site