Messages in this thread | | | Date | Fri, 27 Jan 2023 10:53:44 -0700 | From | Nathan Chancellor <> | Subject | Re: [PATCH] udf: remove reporting loc in debug output |
| |
On Fri, Jan 27, 2023 at 08:29:06AM -0800, Tom Rix wrote: > clang build fails with > fs/udf/partition.c:86:28: error: variable 'loc' is uninitialized when used here [-Werror,-Wuninitialized] > sb, block, partition, loc, index); > ^~~ > > loc is now only know when bh is valid. So remove reporting loc in debug output. > > Fixes: 4215db46d538 ("udf: Use udf_bread() in udf_get_pblock_virt15()") > Signed-off-by: Tom Rix <trix@redhat.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> --- > fs/udf/partition.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/udf/partition.c b/fs/udf/partition.c > index 92765d2f6958..5bcfe78d5cab 100644 > --- a/fs/udf/partition.c > +++ b/fs/udf/partition.c > @@ -82,8 +82,8 @@ uint32_t udf_get_pblock_virt15(struct super_block *sb, uint32_t block, > > bh = udf_bread(sbi->s_vat_inode, newblock, 0, &err); > if (!bh) { > - udf_debug("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u) VAT: %u[%u]\n", > - sb, block, partition, loc, index); > + udf_debug("get_pblock(UDF_VIRTUAL_MAP:%p,%u,%u)\n", > + sb, block, partition); > return 0xFFFFFFFF; > } > > -- > 2.26.3 >
| |