Messages in this thread | | | Date | Thu, 26 Jan 2023 09:49:56 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH 0/8] PCI: rockchip: Fix PCIe endpoint controller driver |
| |
On Thu, Jan 26, 2023 at 04:23:57PM +0100, Rick Wertenbroek wrote: > Le jeu. 26 janv. 2023 à 15:52, Bjorn Helgaas <helgaas@kernel.org> a écrit : > > Thanks very much for your work. > > > > On Thu, Jan 26, 2023 at 02:50:40PM +0100, Rick Wertenbroek wrote: > > > This is a series of patches that fixes the PCIe endpoint controller driver > > > for the Rockchip RK3399 SoC. It is based on Linux kernel 6.0.19 > > > > > > The original driver in mainline had issues and would not allow for the > > > RK3399 to operate in PCIe endpoint mode. This patch series fixes that so > > > that the PCIe core controller of the RK3399 SoC can now act as a PCIe > > > endpoint. > > > > So we merged cf590b078391 ("PCI: rockchip: Add EP driver for Rockchip > > PCIe controller") when it actually didn't work? Ouch. Thanks for > > fixing it and testing it. > > It seems it wasn't fully tested, the code compiles and kernel module loads, > but further functionality didn't seem to have been tested > (e.g., lspci, and with the pcitest tool and pci_endpoit_test_driver).
OK, I guess that happens sometimes. Glad you're getting it into shape!
> Does this mean I should refer to the commit cf590b078391 > ("PCI: rockchip: Add EP driver for Rockchip PCIe controller") ? > Because it wasn't working in the first place ?
Yes, I think so.
> Thank you for all the pointers, I'll take them into account for the > next iteration. This is the first time I actually submitted a series of > patches to the LKML so it's all relatively new to me.
Welcome to Linux, and great start!
Bjorn
| |