lkml.org 
[lkml]   [2023]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2 10/11] staging: rtl8192e: Remove unused variables txbeac.., txman.. and txcmdp..
    txbeaconerr, txmanageokint and txcmdpktokint are initialized and increased
    but never read. Remove dead code.

    Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
    ---
    drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 8 +-------
    drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 3 ---
    2 files changed, 1 insertion(+), 10 deletions(-)

    diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
    index 4cc90425fa4c..2c5edda74e73 100644
    --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
    +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
    @@ -2139,11 +2139,7 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev)
    goto done;
    }

    - if (inta & IMR_TBDER)
    - priv->stats.txbeaconerr++;
    -
    if (inta & IMR_MGNTDOK) {
    - priv->stats.txmanageokint++;
    _rtl92e_tx_isr(dev, MGNT_QUEUE);
    spin_unlock_irqrestore(&priv->irq_th_lock, flags);
    if (priv->rtllib->ack_tx_to_ieee) {
    @@ -2155,10 +2151,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev)
    spin_lock_irqsave(&priv->irq_th_lock, flags);
    }

    - if (inta & IMR_COMDOK) {
    - priv->stats.txcmdpktokint++;
    + if (inta & IMR_COMDOK)
    _rtl92e_tx_isr(dev, TXCMD_QUEUE);
    - }

    if (inta & IMR_HIGHDOK)
    _rtl92e_tx_isr(dev, HIGH_QUEUE);
    diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
    index f8b2201ea288..c6a4ac6ce959 100644
    --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
    +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
    @@ -184,9 +184,6 @@ enum reset_type {

    struct rt_stats {
    unsigned long received_rate_histogram[4][32];
    - unsigned long txbeaconerr;
    - unsigned long txmanageokint;
    - unsigned long txcmdpktokint;
    unsigned long txbytesmulticast;
    unsigned long txbytesbroadcast;
    unsigned long txbytesunicast;
    --
    2.39.1
    \
     
     \ /
      Last update: 2023-03-26 23:55    [W:2.564 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site