Messages in this thread | | | Date | Wed, 25 Jan 2023 11:04:54 -0800 | Subject | Re: [PATCH] drm/msm/dpu: Add DSC hardware blocks to register snapshot | From | Abhinav Kumar <> |
| |
On 1/25/2023 1:13 AM, Marijn Suijten wrote: > Add missing DSC hardware block register ranges to the snapshot utility > to include them in dmesg (on MSM_DISP_SNAPSHOT_DUMP_IN_CONSOLE) and the > kms debugfs file. > > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Huge ack from me,
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index ad08fb7e7105..44648da310f2 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -930,6 +930,11 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k > msm_disp_snapshot_add_block(disp_state, cat->wb[i].len, > dpu_kms->mmio + cat->wb[i].base, "wb_%d", i); > > + /* dump DSC sub-blocks HW regs info */ > + for (i = 0; i < cat->dsc_count; i++) > + msm_disp_snapshot_add_block(disp_state, cat->dsc[i].len, > + dpu_kms->mmio + cat->dsc[i].base, "dsc_%d", i); > + > msm_disp_snapshot_add_block(disp_state, cat->mdp[0].len, > dpu_kms->mmio + cat->mdp[0].base, "top"); >
| |