Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 25 Jan 2023 16:55:52 +0000 | Subject | Re: [PATCH v3 06/11] perf pmu-events: Remove now unused event and metric variables | From | John Garry <> |
| |
On 24/01/2023 06:33, Ian Rogers wrote: > Previous changes separated the uses of pmu_event and pmu_metric, > however, both structures contained all the variables of event and > metric. This change removes the event variables from metric and the > metric variables from event. > > Note, this change removes the setting of evsel's metric_name/expr as > these fields are no longer part of struct pmu_event. The metric > remains but is no longer implicitly requested when the event is. This > impacts a few Intel uncore events, however, as the ScaleUnit is shared > by the event and the metric this utility is questionable. Also the > MetricNames look broken (contain spaces) in some cases and when trying > to use the functionality with '-e' the metrics fail but regular > metrics with '-M' work. For example, on SkylakeX '-M' works:
Reviewed-by: John Garry <john.g.garry@oracle.com>
| ![\](/images/icornerr.gif) |