Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 25 Jan 2023 07:52:09 -0800 | From | Alison Schofield <> | Subject | Re: [PATCH v2] cxl/mbox: Add debug messages for enabled mailbox commands |
| |
On Wed, Jan 25, 2023 at 09:57:28AM +0100, Robert Richter wrote: > Only unsupported mailbox commands are reported in debug messages. A > list of enabled commands is useful too. Change debug messages to also > report the opcodes of enabled commands. Esp. if card initialization > fails there is no way to get this information from userland. > > On that occasion also add missing trailing newlines. > > Signed-off-by: Robert Richter <rrichter@amd.com> > --- > v2: > * Changed message to "Opcode 0x%04x enabled\n". Updated patch > description accordingly.
Thanks Robert, Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> > drivers/cxl/core/mbox.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index a48ade466d6a..202d49dd9911 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -629,11 +629,12 @@ static void cxl_walk_cel(struct cxl_dev_state *cxlds, size_t size, u8 *cel) > > if (!cmd) { > dev_dbg(cxlds->dev, > - "Opcode 0x%04x unsupported by driver", opcode); > + "Opcode 0x%04x unsupported by driver\n", opcode); > continue; > } > > set_bit(cmd->info.id, cxlds->enabled_cmds); > + dev_dbg(cxlds->dev, "Opcode 0x%04x enabled\n", opcode); > } > } > > > base-commit: 1b929c02afd37871d5afb9d498426f83432e71c2 > -- > 2.30.2 >
| ![\](/images/icornerr.gif) |