Messages in this thread | | | Date | Wed, 25 Jan 2023 08:21:42 +0100 | Subject | Re: [PATCH v1 2/3] dt-bindings: net: bluetooth: Add NXP bluetooth support | From | Krzysztof Kozlowski <> |
| |
On 24/01/2023 18:47, Neeraj Sanjay Kale wrote: > Add binding document for generic and legacy NXP bluetooth > chipset. > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> > --- > .../bindings/net/bluetooth/nxp-bluetooth.yaml | 67 +++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml > new file mode 100644 > index 000000000000..d6226838ab1c > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp-bluetooth.yaml
format is vendor,compatible
> @@ -0,0 +1,67 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/net/bluetooth/nxp-bluetooth.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
Drop quotes from both
> + > +title: NXP Bluetooth chips > + > +description: > + This documents the binding structure and common properties for serial > + attached NXP Bluetooth devices.
Drop "This documents the binding structure and common properties"... and replace everything with proper hardware description.
> + > +maintainers: > + - Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> > + > +properties: > + compatible: > + enum: > + - nxp,nxp-generic-bt-chip > + - nxp,nxp-legacy-bt-chip
These are wrong on multiple levels. Duplicated vendor prefix. Not specific compatible. Fake compatible (non-existing device).
> + > + firmware-name: > + description: > + Specify firmware file name. If this property is not > + specified, it is fetched from the user-space config > + file nxp/bt_mod_para.conf > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + &uart1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_uart1>; > + assigned-clocks = <&clk IMX8MM_CLK_UART1>; > + assigned-clock-parents = <&clk IMX8MM_SYS_PLL1_80M>; > + fsl,uart-has-rtscts;
Drop everything above except serial node.
> + status = "okay";
Drop
> + bluetooth { > + compatible = "nxp,nxp-generic-bt-chip";
Wrong indentation. It's 4-space.
> + }; > + }; > + - | > + &uart2 { > + bluetooth { > + compatible = "nxp,nxp-generic-bt-chip"; > + firmware-name = "uartuart_n61x_v1.bin" > + }; > + }; > + - | > + &uart3 { > + bluetooth { > + compatible = "nxp,nxp-legacy-bt-chip"; > + }; > + }; > + - | > + &uart4 { > + bluetooth { > + compatible = "nxp,nxp-legacy-bt-chip"; > + firmware-name = "uartuart8987_bt.bin" > + };
Drop all these above - they do not bring anything.
> + }; > + > +
Best regards, Krzysztof
| |