Messages in this thread | | | Date | Wed, 25 Jan 2023 14:24:50 +0100 | From | Petr Mladek <> | Subject | Re: [PATCH 1/2] powerpc/module_64: Improve restore_r2() return semantics |
| |
On Tue 2023-01-24 19:38:04, Josh Poimboeuf wrote: > restore_r2() returns 1 on success, which is surprising for a non-boolean > function. Change it to return 0 on success and -errno on error to match > kernel coding convention. > > Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Looks good:
Reviewed-by: Petr Mladek <pmladek@suse.com>
It is in the right direction. Just note that there are more functions with the boolean semantic passed via int return value. But there are also other functions already using the 0/-E* return values so this is rather positive change.
Best Regards, Petr
| |