lkml.org 
[lkml]   [2023]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND RFC PATCH v1 10/20] docs: document general_profit sysfs knob
On Tue, Jan 24, 2023 at 09:21:51AM -0700, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>
> > Seems like the wording is confusing me, so I write the improv:
> >
> > ---- >8 ----
> > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-ksm b/Documentation/ABI/testing/sysfs-kernel-mm-ksm
> > index 7768e90f7a8fef..5309a912ab679b 100644
> > --- a/Documentation/ABI/testing/sysfs-kernel-mm-ksm
> > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-ksm
> > @@ -56,6 +56,6 @@ What: /sys/kernel/mm/ksm/general_profit
> > Date: January 2023
> > KernelVersion: 6.1
> > Contact: Linux memory management mailing list <linux-mm@kvack.org>
> > -Description: Measure how effective KSM is.
> > - general_profit: how effective is KSM. The formula for the
> > - calculation is in Documentation/admin-guide/mm/ksm.rst.
> > +Description: Measure the KSM profit. See
> > + :ref:`KSM documentation <monitoring-ksm-profit>` for details
> > + on the calculated formula.
>
> So the original at least attempted to tell us what "KSM profit" is; the
> "improved" version makes no such effort. I don't think that is actually
> better.

I overlooked that, thanks!

--
An old man doll... just what I always wanted! - Clara
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-03-26 23:56    [W:0.077 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site